parodos-dev / workflow-software-templates

Apache License 2.0
0 stars 9 forks source link

move workflow type to a step with conditional inputs for assessment #59

Closed anludke closed 5 months ago

anludke commented 5 months ago

This PR fixes FLPATH-1294, FLPATH-1257 and addresses concerns raised in FLPATH-1293. It should be merged after PR on workflow type.

The update separates the workflow type into a distinct step, which then requests relevant fields specifically for assessments, with no action required for infrastructure. This change ensures that the infrastructure workflow id is correctly linked to the assessment definition, resolving the issue reported in FLPATH-1257.

To mitigate the confusion on data input (sampleText) requested for the assessment workflow and the evaluation perform on that input in order to recommend suitable workflow options, the change is straightforward - if the input is empty, an empty workflow options object is returned; otherwise, a workflow options object is returned with the infrastructure workflow collected from the user.

Additionally, a new link to the workflow type documentation has been added to the Basic template card.

Screenshot 2024-05-07 at 8 12 10 PM Screenshot 2024-05-07 at 8 17 29 PM Screenshot 2024-05-07 at 8 18 23 PM Screenshot 2024-05-07 at 8 18 48 PM Screenshot 2024-05-07 at 8 19 05 PM Screenshot 2024-05-07 at 9 24 23 PM
y-first commented 5 months ago

/lgtm