Delete Shaders properly?

paroj / gltut

Learning Modern 3D Graphics Programming

https://paroj.github.io/gltut/

MIT License

1.57k stars 377 forks source link

Delete Shaders properly? #33

Closed paroj closed 8 years ago

paroj commented 12 years ago

Originally reported by: Pfhreak (Bitbucket: Pfhreak, GitHub: Pfhreak)

Perhaps I'm wrong on the mechanics of C++, but isn't line 54 of the the framework.cpp file unreachable? It looks like you either return the new program or throw an exception and the for each statement will never be reached.

Bitbucket: https://bitbucket.org/alfonse/gltut/issue/64

paroj commented 12 years ago

Original comment by Jason McKesson (Bitbucket: alfonse, GitHub: alfonse):

Yes, you're absolutely right. Good catch.

Fixed in [[https://bitbucket.org/alfonse/gltut/changeset/aa47c45a428e |aa47c45a428e ]]