search

paroj / xpad

Linux Kernel Driver for the Xbox/ Xbox 360/ Xbox One Controllers
845 stars 184 forks source link

Support for Nacon Pro Compact #229

Open guegse opened 1 year ago

guegse commented 1 year ago
paroj commented 1 year ago

please check current master again. probably this is not needed any more

guegse commented 1 year ago

please check current master again. probably this is not needed any more

My 2 controllers have product ids 0x0616 and 0x0618 respectively so I think this PR is still needed for them to work:

$ lsusb
...
Bus 001 Device 007: ID 3285:0616 NACON Pro Compact
Bus 001 Device 006: ID 3285:0618 NACON Pro Compact

General (noob) questions regarding the structure of this driver:

/*
 * Xbox 360 has a vendor-specific class, so we cannot match it with only
 * USB_INTERFACE_INFO (also specifically refused by USB subsystem), so we
 * match against vendor id as well. Wired Xbox 360 devices have protocol 1,
 * wireless controllers have protocol 129.
 */

Does that mean that all vendor and product IDs have to be listed explicitly in the driver for it to work? Would it make sense to make an exception for this driver? Having to list all vendors/products that effectively talk the same protocol seems quite tedious/ineffective.

DJawna commented 6 months ago

Hello will this be merged? because i have a similar problem my nacon controller has the id:

3285:0616

currently i have simply changed the xpad kernel module myself, but i would like to use the official version ;)