search

paroj / xpad

Linux Kernel Driver for the Xbox/ Xbox 360/ Xbox One Controllers
823 stars 182 forks source link

Support KEY_RECORD for 8BitDo Pro 2...for Xbox #231

Closed lbschenkel closed 1 year ago

lbschenkel commented 1 year ago

Support KEY_RECORD for 8BitDo Pro 2...for Xbox

This controller is a "Series S|X": it has the "share" button below the big Xbox button. However, it reports the status of that button in a different offset than the official controller.

The button is still recognized by official Microsoft driver in Windows, so it looks like that both offsets are used in the wild.

Signed-off-by: Leonardo Brondani Schenkel <leonardo@schenkel.net>

lbschenkel commented 1 year ago

I don't have an official "Xbox series S|X" controller to test this on to see if the new offset is always zero on that one. Can you please test this patch with that controller?

lbschenkel commented 1 year ago

Hi. Any feedback on this?

paroj commented 1 year ago

sorry, forgot about this one

lbschenkel commented 8 months ago

Hi @paroj, the situation ended to be a bit more complicated than just adding a new offset. It works but it's more of a hack than an actual fix. I think the best explanation is to see the changes that have been done to the xone driver: https://github.com/medusalix/xone/commit/2679ee25103447113731e6a69550e430328d3285