search

parro-it / electron-google-oauth

Google api access token in electron
MIT License
56 stars 16 forks source link

cannot specify redirect_uri #4

Open mmahalwy opened 8 years ago

mmahalwy commented 8 years ago

I thought this library would be great as a work around the problem with postmessage and the google javascript auth. But I found that this completely changes my flow of my API backend because it assumes an application credential and cannot be shared with my web browser app credentials.

Can this be achieved with redirect_uri postmessage?

parro-it commented 8 years ago

Hi, @gotokatsuya has implemented that in a PR. Pls wait for that PR to land in master.

parro-it commented 8 years ago

And ping me here if the redirect_uri PR doesn't fix your user case.

mmahalwy commented 8 years ago

Will I be able to use postmessage?

parro-it commented 8 years ago

What do you mean by postmessage? Please add more details about your problem.

mmahalwy commented 8 years ago

See Step 4 in: https://developers.google.com/identity/sign-in/web/server-side-flow

Ideally, I want to have postmessage to be set for redirecturi so that a one-time code is sent back from google upon successful auth, and sent to the server to retrieve the full data.

parro-it commented 8 years ago

Thanks you for the details. I read step 4 you've linked. Yes AFAIK mentioned PR should provide the feature you need. I reopen this to remember me to check when I'll merge the PR.

parro-it commented 8 years ago

Tracking upstream issue atom/electron#1865