search

parro-it / electron-google-oauth

Google api access token in electron
MIT License
56 stars 16 forks source link

Add redirecturi #6

Closed mmahalwy closed 8 years ago

mmahalwy commented 8 years ago

@parro-it i tried with postmessage but google has an endless Connecting...

image

Might relate to: https://github.com/atom/electron/issues/1865

parro-it commented 8 years ago

I can't check it today, will do tomorrow. Meanwhile, have you checked in devtools network tab what's happening?

mmahalwy commented 8 years ago

@parro-it yep, nothing at all. It's like google is not responding

parro-it commented 8 years ago

if you use the default value of 'urn:ietf:wg:oauth:2.0:oob' does it works?

parro-it commented 8 years ago

If you look atom/electron/issues/4216 they are discussing this exact situation. This issue is merged with the one you mention.

parro-it commented 8 years ago

Anyway, tomorrow I'll merge your PR in favour of parro-it/electron-google-oauth/pull/3, maybe it solve @gotokatsuya use case too. Thank you!

mmahalwy commented 8 years ago

Yep, but I think the problem is that google is not playing nice with electron when using postmessage

Not sure why.

gotokatsuya commented 8 years ago

Thank you guys! I close my PR :smile:

parro-it commented 8 years ago

Thank you @gotokatsuya