browser-window dependency not found

parro-it / electron-google-oauth

Google api access token in electron

MIT License

56 stars 16 forks source link

browser-window dependency not found #8

Closed mciparelli closed 8 years ago

mciparelli commented 8 years ago

You're attempting to use a browser-window dependency not specified in package.json so this library cannot be used because of this dependency not being found. Nice work though! I like how you abstracted signin for electron apps.

black-snow commented 8 years ago

Leaving a comment to get notices when this is resolved. Would've loved to use this but can't for there is no browser-window.

parro-it commented 8 years ago

@mciparelli , @black-snow, Thank you for the issue!

browser-window is a core Electron module, and not an npm package, so it should not be listed in package.json deps.

However, recent electron releases has changed way browser-window should be required (it's now a property of electron core module).

Please check out version 2.0 where I fixed this issue and also removed some deprecated argument in API...