search

parroty / excheck

Property-based testing library for Elixir (QuickCheck style).
MIT License
316 stars 26 forks source link

Added possibility to specify amount of tests in config #13

Closed luc-tielen closed 8 years ago

parroty commented 8 years ago

Thanks, it sounds nice. Just confirmation, but can I understand it's independent from #12? (can be separately merged?)

luc-tielen commented 8 years ago

Yes, this is something completely different :) I wanted the option to specify how many tests are being ran each time (per environment). I just tried merging both PR's onto master, there is a slight merge conflict in the README but no problems in the code itself. (README should contain updates from both branches, easy fix).

parroty commented 8 years ago

Thanks!

parroty commented 8 years ago

I just realized this setting doesn't work for ExCheck.check(module_name) and found https://github.com/krestenkrab/triq/pull/54 along with it. Before it gets merged, I am thinking to add a conditional logic to use :triq.module as above (does it make sense?)

luc-tielen commented 8 years ago

Ah I should've mentioned that.. I would keep logic the way it is since no errors will happen (just wrong amount of tests), hopefully krestenkrab accepts that small pull request soon and then everything will be streamlined and work as intended again.

parroty commented 8 years ago

OK. At the moment, I'll just put reference in the readme to this issue item and wait for the merge (and then revisit sometime later. Need to upgrade the dependency anyway).

luc-tielen commented 8 years ago

krestenkrab/triq#54 has been merged in! This pull request should now work with triq:module/2 too. :smiley:

parroty commented 8 years ago

Nice :+1: