Fix umbrella test count

parroty / excheck

Property-based testing library for Elixir (QuickCheck style).

MIT License

316 stars 26 forks source link

Fix umbrella test count #34

Closed luc-tielen closed 7 years ago

coveralls commented 7 years ago

Coverage increased (+2.2%) to 75.789% when pulling 82e88224234bba5afb5682909e8e9d017b20b9eb on luc-tielen:fix_umbrella_test_count into a876a7314be21f6a0ccb52f8f0e6ca51c333b429 on parroty:master.

luc-tielen commented 7 years ago

Fixes #33.

Looks like tests in CI build fail because of following reason: ** (UndefinedFunctionError) undefined function: MapSet.new/1 when doing mix deps.get (package jsx)

(But when running locally they are fine for me.) @parroty or @myronmarston can you re-run/verify manually?

luc-tielen commented 7 years ago

So, any updates on this @parroty? Been almost a week now. If the build failure is a problem, it's an error in hex for Elixir version 1.1.1, due to MapSet.new not being available there. Maybe a separate issue should be created to fix it (and potentially add other more recent versions of Elixir too.)

parroty commented 7 years ago

Thanks and very sorry taking time to merge.

luc-tielen commented 7 years ago

No problem, glad it got merged in :)