parroty / excoveralls

Coverage report tool for Elixir with coveralls.io integration.
MIT License
821 stars 178 forks source link

Elixir 1.11: :eex and :tools should be listed in :extra_applications #233

Closed ahamez closed 3 years ago

ahamez commented 3 years ago

Warnings were:

warning: EEx.eval_file/2 defined in application :eex is used by the current application but the current application does not directly depend on :eex. To fix this, you must do one of:

  1. If :eex is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :eex is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :eex, you may optionally skip this warning by adding [xref: [exclude: EEx] to your "def project" in mix.exs

Found at 2 locations:
  lib/excoveralls/html/view.ex:27: ExCoveralls.Html.View.render/1
  lib/excoveralls/html/view.ex:31: ExCoveralls.Html.View.partial/2

and

warning: :cover.analyse/3 defined in application :tools is used by the current application but the current application does not directly depend on :tools. To fix this, you must do one of:

  1. If :tools is part of Erlang/Elixir, you must include it under :extra_applications inside "def application" in your mix.exs

  2. If :tools is a dependency, make sure it is listed under "def deps" in your mix.exs

  3. In case you don't want to add a requirement to :tools, you may optionally skip this warning by adding [xref: [exclude: :cover] to your "def project" in mix.exs

  lib/excoveralls/cover.ex:47: ExCoveralls.Cover.analyze/1
coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.05%) to 89.778% when pulling 12c620bb05348e11f7bb003681d05c4d7849d9b2 on ahamez:master into 454bf4936a0f9699636bf6b9348595d4580ef1ce on parroty:master.

parroty commented 3 years ago

Thanks for the PR! Please let me merge the #234, as this item seems to be part of the change.