search

parroty / excoveralls

Coverage report tool for Elixir with coveralls.io integration.
MIT License
826 stars 178 forks source link

Add a task to upload coverage from gitlab #240

Closed ggpasqualino closed 3 years ago

ggpasqualino commented 3 years ago

Hi there, I see the example uses the native coverage of GitLab. I would like to use coveralls though because of the parallel feature. What do you think? Would it make sense to add that?

Cheers

parroty commented 3 years ago

Thanks for the PR. If it does not affect the existing behavior, it may make sense to add the capability, but could I request some description (or reference) regarding the usage? (or any sample would be helpful).

ggpasqualino commented 3 years ago

@parroty awesome :) I have made this demo repo to describe the usage https://gitlab.com/ggpasqualino/excoveralls-demo/

parroty commented 3 years ago

Thanks for providing example.

ggpasqualino commented 3 years ago

Thanks for providing example.

  • Please let me ask how the token (COVERALLS_REPO_TOKEN) is being passed for your demo repository?

    • It's configured as part of GitHub CI settings? (I'm trying to fork the repository to my account and checking the behavior).

Yes, you can find the place to set it up under https://gitlab.com/ggpasqualino/excoveralls-demo/-/settings/ci_cd#Variables just replace my user with yours :)

  • Can I fork (or link the) demo repository to put the reference in the README?

Yes, for sure you may fork it and link it in the README

parroty commented 3 years ago

Thanks for the clarifications. I've updated the reference as https://gitlab.com/parroty/excoveralls-demo/ (also added small note about COVERALLS_REPO_TOKEN environment variable).