Open duksis opened 1 year ago
Thank you for the feedback 🙇 . I assume it's related to https://github.com/parroty/excoveralls/pull/286.
While it may make sense to have that feature for mix coveralls.json
, my concern is that it can become a breaking change. If it can be taken as optional feature, it might be good to add that capability, though.
@parroty couldn't find any reports here but the same thing happens with coveralls.github
the min coverage is just ignored.
+1 for not ignoring minimum_coverage
when running mix coveralls.github
too
I'm currently seeing this situation on GitHub Actions:
coverage/coveralls Expected — Waiting for status to be reported
Even though coverage is visible on their website:
Successfully uploaded the report to 'https://coveralls.io/'
To work around that (for now), I could disable the branch requirement for coverage/coveralls
. But it would be nice if the coveralls.json
minimum_coverage
setting would act as a fallback in that situation, so we still fail CI if coverage falls too much.
Thank you for the comment 🙇 . I am now checking this item through #305.
First of all - thanks for your work!
currently
min_coverage
option seems to only be taken into account when usingmix coveralls
andmix coveralls.html
tasks.https://github.com/parroty/excoveralls/blame/b706b5da6d3a62ff51552059cf57726c6ad104e5/README.md#L426...L427
I would like to use the min_coverage option and generate a json file.
if I understand that right I would need to run my test suite twice in order to achieve both - the failure on below min_coverage and a json file.
I would prefer not to do that.
1) Is there another way to achieve both? 2) would it make sense to check min_coverage in
mix coveralls.json
?Thanks