Open vereis opened 1 year ago
@parroty ahoy! Any thoughts on this PR? Happy to keep iterating on it if you think there is anything missing?
Following up on this as well. Ran into this at work and didn't realize that coveralls.json didn't support the minimum coverage. Would love to see it work for that
Likewise for coveralls.github
-- kind've expected that to be the default behaviour, to be honest.
Hey! I'm very interested on these changes. Any plans to merge it anytime soon?
Hello! What is the status of this PR? Is there anything blocking this from merging?
I'm sorry being not responsive. I appreciate any help resolving conflicts.
Ahoy again!
This PR implements a new flag to
excoveralls
:--enforce-minimum-coverage
. When this is provided, we always runStats.ensure_minimum_coverage/1
regardless of what testing type you're running.For example:
I've refactored the existing type implementations that call
Stats.ensure_minimum_coverage/1
by default and removed these calls. Instead, when runningMix.Tasks.Coveralls.do_run/2
I check to see if the type requested was eitherhtml
,local
, orcobertuna
and if so, I automatically set--enforce-minimum-coverage
to retain backwards behavioural compatibility.Closes #297