search

parroty / excoveralls

Coverage report tool for Elixir with coveralls.io integration.
MIT License
820 stars 178 forks source link

Replace hackney with httpc #311

Closed whatyouhide closed 1 year ago

whatyouhide commented 1 year ago

This is the start of the work proposed in https://github.com/parroty/excoveralls/pull/231.

The main missing thing is Security™, that is, I need to add all the right SSL options to make the :httpc request secure. I'll work on that this afternoon if there is interest in this, @parroty?

Btw @parroty, also feel free to send me an email (email is on my GitHub profile) or write me a DM on Twitter to chat about helping out with maintaining this library 🙃

parroty commented 1 year ago

Thanks. It's a little hectic week for me, but try to send message on the weekend / next week.

whatyouhide commented 1 year ago

@parroty hello! Any news on this? 🙃

whatyouhide commented 1 year ago

@parroty ping 🙃 Would love to get an email and chat! 😉

whatyouhide commented 1 year ago

@parroty ping 🏓 🙃

whatyouhide commented 1 year ago

@parroty I added SSL support here too, based on esbuild.

parroty commented 1 year ago

Sorry being slow to respond. I am seeing actions errors, but haven't been able look into it. Do you have any idea?

whatyouhide commented 1 year ago

@parroty let's start out with https://github.com/parroty/excoveralls/pull/316 😄

whatyouhide commented 1 year ago

@parroty finally fixed tests in CI on the supported versions, so this is ready to merge!!! Exciting times ahead. 💟

whatyouhide commented 1 year ago

@parroty any news on this? 🙃

whatyouhide commented 1 year ago

Tested this out in Xandra, works good 🙃

whatyouhide commented 1 year ago

Woohooo! Thanks @parroty. Looking forward to a release 😉