search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
722 stars 132 forks source link

Adding filter_request_options to filter sensitive data in request options #102

Closed ecarnevale closed 7 years ago

ecarnevale commented 7 years ago

Hi, I was using exvcr for a project that needs to connect to an external API using basic_auth to get a cookie (and then use that cookie for all the consequent requests). Using HTTPoison and hackney, I have to pass the basic_auth parameters trough the options and I discovered it was impossible to filter those data.

Hope this PR is useful for others too :)

Emanuel

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 92.461% when pulling 779be0a609d91a53b6be7c2b00aaf2cacf149726 on ecarnevale:master into 981c5de932bf0628c0fce3e1a6fdb1cccc4bd692 on parroty:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 92.683% when pulling 05ed78ed4c83cffc9567e4d4c612cced651a4e16 on ecarnevale:master into 981c5de932bf0628c0fce3e1a6fdb1cccc4bd692 on parroty:master.

parroty commented 7 years ago

Thanks!