search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
720 stars 131 forks source link

Allow ExVCR.Config.filter_request_headers to receive a list of headers #131

Open rafaels88 opened 6 years ago

rafaels88 commented 6 years ago

Currently, it is not possible to do something like, ExVCR.Config.filter_request_headers(["header_one", "header_two"]).

This PR makes this possible.

Since ExVCR.Config.filter_request_headers is a plural term (headers) and it is possible to give a list of values when defining this config on config.exs as filter_request_headers: [], it seems that it is really non-intuitive the fact of giving a list of values to the function, it does not work (also no errors happen).

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.01%) to 93.697% when pulling 77825ff6304d4ad45c2a93a56524f11c22791bfc on rafaels88:allow-filter_request_headers-get-a-list into fdf598819449aacb123ee1025de29e70908a27b0 on parroty:master.