search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
720 stars 131 forks source link

Fix ignore localhost when using headers #139

Open dgb opened 6 years ago

dgb commented 6 years ago

Fixes the ignore_localhost option when recording requests that send headers. This was raising an ArgumentError because every element of the request was being enumerated and checked as a String (including non-string-like maps, which is how headers are represented).

This changes the checking of the url to get the url out of the request via the corresponding adapter.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.5%) to 93.317% when pulling eca7cdd63210643dd1bc545facfa811c5f9a5403 on dgb:master into 188224357a2106e021e872e20d358f20d38ac9cf on parroty:master.

parroty commented 5 years ago

Sorry not responding for a long time. Does merging https://github.com/parroty/exvcr/pull/140 resolve the issue?

dgb commented 5 years ago

@parroty probably--it looks like a similar fix. I'm not on a project which uses exvcr right now though, so I'm not able to confirm unfortunately. When I have a bit more time later this week I'll try and verify and update this ticket.

kacorvus commented 1 year ago

Close this as abandoned?

parroty commented 1 year ago

Hi. Are you still observing the issue? I was assuming it was resolved, but didn't have good chance to close this item.