search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
720 stars 131 forks source link

Enforce match on :hackney.request/1, /2, /3 and /4 #145

Closed frm closed 4 years ago

frm commented 4 years ago

Fixes #144.

When calling either of

:hackney.head(url)
:hackney.request(:head, url)

no request is matched in the target_methods/1 call, due to the fact that in Hackney head function calls in hackney don't call the body function.

As a result, when making :hackney.head/1 calls, the request hits the destination instead of being captured.

I'm not sure if this is the best option to do so, but adding defaults seemed a sensible option.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.7%) to 92.929% when pulling 67480d0c1b112528c865913d7fce8854711baea8 on frm:master into 7bd7aa2f518886d5fd8dc9dfde04be828a7817b1 on parroty:master.

parroty commented 4 years ago

Thanks!