parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
720 stars 131 forks source link

Allow json toolkit lib to be configurable #154

Closed julien-leclercq closed 3 years ago

julien-leclercq commented 4 years ago

Hello, As promised in #153 here is my Pull request for configurable json toolkit usage in exvcr. I tried to stick with your coding style but a .formatter.exs file would be very welcome as your project is not following the elixir standard default format.

If you want some more detailed explanation, or documentation just say it and I will provide.

I kind of struggled to have a good way of testing this, suggestions welcome.

Good day and hope you and your relatives are safe in these weird days.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.8%) to 91.386% when pulling c08d5d41a409bf646a4040d2d320655442a048aa on fewlinesco:issue153 into dcd54f05f3226bce8a5f5b9ffab2f5f5839027f7 on parroty:master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-1.9%) to 91.248% when pulling 5d11afa645f3fccd728e5c039b25ff40e68d40e8 on fewlinesco:issue153 into dcd54f05f3226bce8a5f5b9ffab2f5f5839027f7 on parroty:master.