Define Finch adapter conditionally to fix compile error

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.

MIT License

714 stars 133 forks source link

Define Finch adapter conditionally to fix compile error #178

Closed reisub closed 2 years ago

reisub commented 2 years ago

If there is no Finch dependency error, the compile for the project using ExVCR fails. Thanks to @ruslandoga for noticing and giving a suggestion for the fix!

As suggested, we define the adapter module conditionally and raise if the adapter is used without a Finch dependency loaded.

Ideally we should also figure out a way to test this case, but for now let's just release a new version to minimize any inconvenience - sorry for this oversight on my part!

coveralls commented 2 years ago

Coverage remained the same at 88.764% when pulling 38cb324c125fa323a83139c78f7fb9de7ba7ec74 on reisub:fix/finch-conditional-loading into b458a039f7a5ab02265488238c00ef89a7e37eee on parroty:master.