parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
724 stars 132 forks source link

Support Finch request! function #197

Closed jwien001 closed 1 year ago

jwien001 commented 1 year ago

Finch 0.16.0 was released on 2023-04-13 and adds a request! function.

This branch adds support for the new request! function in the Finch adapter.

jwien001 commented 1 year ago

Hi @parroty, have you had a chance to look at this? Please let me know if there are any changes you'd like me to make.

coveralls commented 1 year ago

Coverage Status

Coverage: 88.474% (-0.3%) from 88.784% when pulling 43306b40e02e0c1f1832031caec5478eed2c99c8 on jwien001:jw-support-finch-request-bang into c6bfe6f3f97ece2d7e378796de3d555f125625f9 on parroty:master.

parroty commented 1 year ago

Thank for the PR and sorry for the late response. I am trying to fix the workflow (maybe not related to this change), and please allow some more time 🙇 . Also, it seems the actions is not working well right now.

parroty commented 1 year ago

Thank you for the PR! (and sorry being late to merge) 🙇