fix: match request body json otp26

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.

MIT License

714 stars 133 forks source link

fix: match request body json otp26 #213

Closed barnabasJ closed 7 months ago

barnabasJ commented 10 months ago

I tried to upgrade to otp 26 today. But I couldn't get my tests to work because I'm using this for recording graphql queries, and the variables weren't always matched in the body because they weren't always in the same order.

This is my naive approach to fixing it. Let me know what you think and what changes you like.

I also plan to add tests, probably tomorrow

barnabasJ commented 10 months ago

There is probably a better way and place for the test. I also was unable to get the test to break in this case.

coveralls commented 10 months ago

coverage: 91.949% (-0.9%) from 92.857% when pulling 945ba9476ba809d4a20b9ea1a0272e9f53832ab8 on barnabasJ:fix/match_request_body_json_otp26 into 5023de6686fe805444768e83b5012f2664922bdb on parroty:master.

parroty commented 7 months ago

Thanks and sorry being late to respond 🙇