search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
724 stars 132 forks source link

Fix upstream warnings under Elixir 1.16 #215

Closed marcelotto closed 8 months ago

marcelotto commented 10 months ago

In preparation for Elixir 1.16, this pull request fixes missing empty parentheses warnings for function calls without arguments. This change is crucial in addressing a new behavior in Elixir, as detailed in Elixir issue #13091. Previously, omitting parentheses in such function calls in ExVCR would generate warnings only when compiling ExVCR itself. However, with Elixir 1.16, these warnings have become upstream warnings. This means they now also appear when compiling code that uses ExVCR, especially in modules that use ExVCR.Mock. So, this affects essentially all ExVCR users and is particularly problematic for those employing the --warnings-as-errors flag in their CI environments, which is quite common.

While I was at it, I removed all such warnings (i.e. also outside of macros).

mtrudel commented 9 months ago

This is hitting us as well, and the blocking error here looks trivial (the PR contains an extra set of double params in one location). Any chance I can entice y'all to get this over the line?

parroty commented 8 months ago

I'm very sorry being late to take action. Thank you for the PR 🙇.