Fix hackney adapter to work with `:with_body` option.

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.

MIT License

722 stars 132 forks source link

Fix hackney adapter to work with `:with_body` option. #79

Closed myronmarston closed 7 years ago

myronmarston commented 7 years ago

There were a couple issues:

sanitize_options assumed that every value in options is a tuple, but hackney supports some boolean options being specified just as atoms:

https://github.com/benoitc/hackney/blob/1.6.3/src/hackney.erl#L1016-L1019

When :with_body is provided, the return value from :hackney.request/5 has the body as the last element in the tuple instead of the client.

These two issues affect both recording and replaying of cassettes, so I added tests for both sides of it.

coveralls commented 7 years ago

Coverage increased (+0.3%) to 93.692% when pulling 955e0cc19bde93a1aa8c0ac7267465cb9a9b6413 on seomoz:myron/fix-hackney-with-body into b849240eff48484b124c3e99783d1d091259bb65 on parroty:master.

myronmarston commented 7 years ago

There's a 3rd issue I found and fixed in the 2nd commit.

coveralls commented 7 years ago

Coverage increased (+0.3%) to 93.735% when pulling ab692f58c024b4dc4d84724d5c929b6917953987 on seomoz:myron/fix-hackney-with-body into b849240eff48484b124c3e99783d1d091259bb65 on parroty:master.

parroty commented 7 years ago

Thanks!!