Prototype of recording streaming requests

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.

MIT License

722 stars 132 forks source link

Prototype of recording streaming requests #85

Open kpanic opened 7 years ago

kpanic commented 7 years ago

Hi @parroty regarding https://github.com/parroty/exvcr/issues/75 I have sketched this bare bone prototype. It recorded my responses when using a streamed request, however I would like to hear from you before giving to it another go.

Thanks a lot!

coveralls commented 7 years ago

Coverage decreased (-0.6%) to 93.088% when pulling 3c8ce0f7ba0bb28aedec358bb2faaf8c72adf612 on kpanic:stream-reqs-prototype into 26630508b6c1c4225926663b5dee42c301f51edb on parroty:master.

parroty commented 7 years ago

Thanks, I wasn't thinking about this approach. Is it possible for you to write a test for this scenario (or post your example?)

kpanic commented 7 years ago

Yes sure, I will try this weekend and try to solve this NOTE https://github.com/parroty/exvcr/pull/85/files#diff-cb27aa72b4049243f7b92ffeaa64c822R67 that I put