search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
722 stars 132 forks source link

Remove elixir 1.4 deprecations #86

Closed clekstro closed 7 years ago

clekstro commented 7 years ago

Elixir 1.4 deprecates the use of defoverridable with private functions and recommends using Enum.uniq_by/2 instead of Enum.uniq/2.

This was adding a fair bit of noise to my test suite after upgrading, so assuming this is merged it might be good to get a new version released so others don't run into it.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.735% when pulling 991227762ba8d1fd85788ac3a63b587fb18529e6 on clekstro:remove-elixir-1.4-deprecations into 26630508b6c1c4225926663b5dee42c301f51edb on parroty:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.735% when pulling 6c7419c29b36f464c90a48ace55ea98361c13a82 on clekstro:remove-elixir-1.4-deprecations into 26630508b6c1c4225926663b5dee42c301f51edb on parroty:master.

parroty commented 7 years ago

Thanks!