Tidy up the applications list

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.

MIT License

722 stars 132 forks source link

Tidy up the applications list #87

Closed josevalim closed 7 years ago

josevalim commented 7 years ago

Not all applications you depend on were specified and applications that you require only in dev/test were listed.

I have not verified this is correct but it is a push in the right direction. Please read this blog post for more information: http://blog.plataformatec.com.br/2016/07/understanding-deps-and-applications-in-your-mixfile/

This may break the test suite but you can fix it by calling Application.ensure_all_started(:http_server) in your test_helper.exs.

coveralls commented 7 years ago

Coverage decreased (-15.3%) to 78.422% when pulling a84d3e5e9e9b08b114463131097f5299f34c1707 on josevalim:patch-1 into b6237c5f65a57c2d6f03c1909739590e246a31b6 on parroty:master.

wojtekmach commented 7 years ago

Btw, for some extra context, folks ran into issues in Elixir v1.4 with the current application list: https://elixirforum.com/t/mix-test-error-in-elixir-1-4-could-not-find-application-file/3255

parroty commented 7 years ago

Thanks for the fix and explanation, I'll be updating along with the change for test_helper.exs.