search

parroty / exvcr

HTTP request/response recording library for elixir, inspired by VCR.
MIT License
722 stars 132 forks source link

Load configuration for cassette paths for mix tasks #88

Closed alakra closed 7 years ago

alakra commented 7 years ago

The Problem

When running the Mix tasks defined in this project, they would only use the hard-coded default paths for recorded and custom cassettes and not consider the config. This demonstrates different configuration behavior between managing cassette data when running tests and managing cassette data from mix tasks.

Proposed Changes

These changes now look at the Mix.Config related to exvcr and use those directories if they are not specified on the CLI and then fallback to the defaults if a custom config is not used in both the context of the project's Mix tasks and running tests.

References

Related to Issue https://github.com/parroty/exvcr/issues/82

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.735% when pulling 6e8a1fd2b312d7a586e034f8c9fa910812ad6b25 on alakra:load_configuration_for_cassette_paths_for_mix_tasks into e5c94d9ae737f3668ab6e20ae041b03de19967c1 on parroty:master.

alakra commented 7 years ago

@parroty Thanks for taking the time to make this project and to look at this PR! :heart: :heart: :heart:

parroty commented 7 years ago

Thanks for digging into the issue item!