Improve _ctreeviz_univar()

parrt / dtreeviz

A python library for decision tree visualization and model interpretation.

MIT License

2.94k stars 331 forks source link

Improve _ctreeviz_univar() #227

Closed mepland closed 1 year ago

mepland commented 1 year ago

Compute bins only when needed
Fix crash for 0 count bins
Fix split heights changing in for loop
Make new 'preds' key in show param to separately control the horizontal prediction bars
Add ValueError for unrecognized gtype
Match other rectangle rect_edge color style

mepland commented 1 year ago

Added tesselation_alpha to let user make horizontal 'preds' bars transparent if they wish

parrt commented 1 year ago

The prediction bars look like they are overlapping the bottom of the bar charts. Is this the previous behavior and I just didn't notice? dang. This PR looks fine, but let's leave this open until we can resolve this issue I just raised. Seems like the prediction should go below the axis not on top of the others.

mepland commented 1 year ago

The prediction bars look like they are overlapping the bottom of the bar charts. Is this the previous behavior and I just didn't notice? dang. This PR looks fine, but let's leave this open until we can resolve this issue I just raised. Seems like the prediction should go below the axis not on top of the others.

@parrt https://github.com/parrt/dtreeviz/pull/227/commits/3a72aa21753659abb83aef4770e4aa9357cd1d12 moves the 'preds' boxes below the regular x-axis, which is then redrawn. What do you think?

parrt commented 1 year ago

What do you think?

looks great!

mepland commented 1 year ago

@parrt I think we should remove the tesselation_alpha parameter, now that overlaps are impossible. I can do it in a new branch and PR.

parrt commented 1 year ago

That sounds right. Thank you

mepland commented 1 year ago

That sounds right. Thank you

Done, see https://github.com/parrt/dtreeviz/pull/235