search

parrt / dtreeviz

A python library for decision tree visualization and model interpretation.
MIT License
2.89k stars 333 forks source link

Make all random calls reproducible #255

Open mepland opened 1 year ago

mepland commented 1 year ago

Only one np.random call is proceeded by a np.random.seed(0) call. We should review and make sure all random calls have seeds set and thus are reproducible.

parrt commented 1 year ago

I wonder if we should simply remove those calls to seed() and then allow the user to specify a seat at the start of their notebook?

mepland commented 1 year ago

@parrt, if we did that the plots would be reproducible only if the user executed their notebook / code in the same order. I think it would be better to set the seed within each plotting function.