linting and cleanup - Githubissues

parrt / tensor-sensor

The goal of this library is to generate more helpful exception messages for matrix algebra expressions for numpy, pytorch, jax, tensorflow, keras, fastai.

https://github.com/parrt/tensor-sensor

MIT License

771 stars 39 forks source link

linting and cleanup #28

Closed sbrugman closed 3 years ago

sbrugman commented 3 years ago

Linting using black and several cleanups while preparing the tensor element type feature

parrt commented 3 years ago

hi. not sure about reformatting but lint stuff useful. let me look. First, i have to fix the pdf PR as it stripped the fully-qualified path ;) haha

sbrugman commented 3 years ago

Two other minor points:

matricks_old.py may be removed?
The color variable in https://github.com/parrt/tensor-sensor/blob/master/tsensor/viz.py#L453 is not used

parrt commented 3 years ago

Yep, already removed that file. i'll look at color.

parrt commented 3 years ago

Hi. Lots of ' -> " type changes and other non-semantic changes. Hmm...not sure we should make a major change just for spacing, though some are definitely worthwhile. Also some dead code it identified. i guess I'll cherry pick on this one. thanks though!!

parrt commented 3 years ago

Ok, i cherry picked a bunch but didn't grab the reformatting wholesale. closing...gave you credit in the commit message.