search

parse-community / Parse-SDK-Android

The Android SDK for Parse Platform
https://parseplatform.org/
Other
1.88k stars 734 forks source link

Rename functions that cause shadow members #1054

Closed oliveiradev closed 4 years ago

oliveiradev commented 4 years ago

Problem

Some extension functions cause shadow member function, it means that the member function of the extended class always have the preference when the IDE shows suggestions.

Porpuse

I renamed some extension function's name to use coroutine prefix, it solves the problem but I do not know if this name is the best option.

I'm open to suggestions

Resolve #1016

Jawnnypoo commented 4 years ago

I think that suspend could be a better prefix. While we are making changes here, can we also change the package of all these functions to com.parse.coroutines with all these methods in the same package? (can still be in different files)

oliveiradev commented 4 years ago

Good, I think that it makes sense

Jawnnypoo commented 4 years ago

Thanks a bunch @oliveiradev !