Closed Jawnnypoo closed 2 years ago
Updated! Yep, this would be a 1.27.0 release
Great, can you add the PR link in the change log entry?
I added the PR link and removed the version from the changelog as the version doesn’t exist yet.
I wonder why the CI fails, can’t see that well on mobile.
Oh yeah not sure about CI. We should leave in the version though because I will release it after this PR is merged in.
I assume we should move from Travis CI to GH Actions at some point, the failing CI does not seem related to any tests.
Yeah, I am all for moving over.
@Jawnnypoo could you take a look and resolve the conflicts? we would merge this to prepare for a 2.0.0 release; if you merge master into this branch, the CI already works
Is this PR a breaking change? Or is GCM not supported anymore anyway and therefore we are just removing it
@L3K0V Is this good to merge in your opinion? (I can't select your name for review request yet)
Merging #1091 (bf6acd4) into master (135d94b) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1091 +/- ##
=========================================
Coverage 65.06% 65.06%
Complexity 2208 2208
=========================================
Files 122 122
Lines 9463 9463
Branches 1317 1317
=========================================
Hits 6157 6157
Misses 2799 2799
Partials 507 507
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 135d94b...bf6acd4. Read the comment docs.
LGTM
No longer supported