search

parse-community / Parse-SDK-Android

The Android SDK for Parse Platform
https://parseplatform.org/
Other
1.88k stars 735 forks source link

Updated dependencies + related changes. #1103

Closed mobilekosmos closed 2 years ago

mobilekosmos commented 2 years ago

Notes:

  1. minSDK changed to 21 (In my opinion there is no reasson to support plattforms which are not even supported by their producers anymore and are full of security flaws, so I would recommend to go even higher than 21).
  2. Jacoco stuff also updated but uncommented because I was getting compilation issues in my testing proyect which I was not able to solve.
  3. Published modules are published without javadoc, TODO in code.
mobilekosmos commented 2 years ago

The build is failing, I took a look but I'm not experienced with that system, locally it compiles without problem, and using it in a test proyect also work. Btw. there is one warning in the build output: "No build-tools version is specified in android.components. Consider adding one of:" Since some time this is not required anymore, only optional, is the build system up to date? It says The following versions are pre-installed: build-tools-25.0.2, so this is a really old version already. It seems that the isntalled python version is also outdated. Please if you could check.

mtrezza commented 2 years ago

@L3K0V Is this PR still needed after https://github.com/parse-community/Parse-SDK-Android/pull/1095?

azlekov commented 2 years ago

@mobilekosmos did good job here, but most of it was already covered by the #1095 @mtrezza

mtrezza commented 2 years ago

Is there anything that can/should be taken from this PR? Or is it better to close it and start fresh, given the many changes that were merged in #1095?

azlekov commented 2 years ago

@mtrezza let's close it and I will encourage @mobilekosmos to check again and open PR with further improvements if any

mobilekosmos commented 2 years ago

Oh noooo, I worked like 1 week updating all, #1095 doesn't even update the gradle plugin.

mtrezza commented 2 years ago

reopened 🙂 do you want to bring this up-to-date with master?

minSDK changed to 21 (In my opinion there is no reasson to support plattforms which are not even supported by their producers anymore and are full of security flaws, so I would recommend to go even higher than 21).

This is actually a good point. We should remove support for APIs that are out of long-term-support. We do the same with Node.js and MongoDB for Parse Server. This also gives us a guidance for how long to support APIs. What is the lowest maintained Android API?

mobilekosmos commented 2 years ago

Android 12 was released in beta in mid-May 2021, and Google plans to officially retire Android 9 in the fall of 2021.

Despite above declaration I won't go to that extrem, since it's not my library I would say minSDK=26 (Android 8.0), that's like already 6 years old. Would it be my own library I would be more agressive and set mindSDK=28

Btw. I made another branch where I will try to merge the current master. Will then do a new PR.

mtrezza commented 2 years ago

Sounds good, so I'll close this PR again.

azlekov commented 2 years ago

I'm also for updating the version to SDK 21 but also OkHttp should be updated as well for sure when updating the SDK version. @mobilekosmos do you want to handle this in your PR - updating do SDK 21 and updating the OkHttp to latest version?

mtrezza commented 2 years ago

How we set the API versions liked requires a discussion. I opened https://github.com/parse-community/Parse-SDK-Android/issues/1123 for that.