parse-community / Parse-SDK-Android

The Android SDK for Parse Platform

https://parseplatform.org/

Other

1.88k stars 739 forks source link

fix: upgrade Facebook SDK #1105

Closed sommye-ctr closed 2 years ago

sommye-ctr commented 2 years ago

In accordance with #1104 I changed the Facebook for Android SDK version from 6.3.0 to 8.2.0. Also, as recommended by RoboElectric, I have updated its version to 4.2.1 to fix the parsing in windows.

mtrezza commented 2 years ago

Thanks for the PR! Let's merge https://github.com/parse-community/Parse-SDK-Android/pull/1095 first so we also have the CI working.

azlekov commented 2 years ago

@mtrezza as this PR overlaps a lot with #1095, may I update the Facebook SDK there as well? What do you think?

codecov[bot] commented 2 years ago

Codecov Report

Merging #1105 (5f3bcba) into master (a977d11) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1105   +/-   ##
=========================================
  Coverage     65.06%   65.06%           
  Complexity     2208     2208           
=========================================
  Files           122      122           
  Lines          9463     9463           
  Branches       1317     1317           
=========================================
  Hits           6157     6157           
  Misses         2799     2799           
  Partials        507      507

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a977d11...5f3bcba. Read the comment docs.

mtrezza commented 2 years ago

Interesting that this only required to bump the SDK but no code changes.

azlekov commented 2 years ago

@mtrezza I will take care if there are reported new issues regarding Facebook sdk upgrade. Currently I do not have project to test with.

sommye-ctr commented 2 years ago

I think I'll be working on a project using the Facebook SDK soon. I'll update if there's any problem.

mtrezza commented 2 years ago

I should also be able to test in the next days. I merged it anyway for an alpha release and if really FB doesn’t work, then we are actually missing some tests.