Closed mobilekosmos closed 2 years ago
❌ Please check all required checkboxes at the top, otherwise your pull request will be closed.
⚠️ Remember that a security vulnerability must only be reported confidentially, see our Security Policy. If you are not sure whether the issue is a security vulnerability, the safest way is to treat it as such and submit it confidentially to us for evaluation.
@mobilekosmos could you add a description to this PR and resolve the conflicts, so we can get this ready for review?
I suppose the conflicts happened after my PR since I started a new fresh PR because of prior conflicts and many changes. What description? The title already describes the work I did? The few dependencies I remoevd were already discussed/asked for in the old PR, they were removed because not used/not needed anymore. I resolved the conflicts.
Others will have a hard time understanding what this PR is about without looking into the code. To make this easier we have a PR template. See this.
There is also a min API bump to 21, which is a breaking change. It helps the committer a lot if you clearly indicate a breaking change in the PR description. This helps to make sure that a breaking change is marked as such in the changelog.
I am closing this as it lacks information about the issue that this PR intends to solve. Feel free to comment if you have any questions and we can re-open this PR.
New Pull Request Checklist
Issue Description
Related issue: #
FILL_THIS_OUT
Approach
TODOs before merging