Closed Shvet closed 2 years ago
Related issue: #123
in the PR description, so I can recognize it.@Shvet can you please review all checkboxes in the description? Could you also take a look at the lint issue reported?
Merging #1150 (5c2e354) into master (447f972) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1150 +/- ##
=========================================
Coverage 66.81% 66.81%
Complexity 2249 2249
=========================================
Files 121 121
Lines 9892 9892
Branches 1332 1332
=========================================
Hits 6609 6609
Misses 2771 2771
Partials 512 512
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 447f972...5c2e354. Read the comment docs.
@Shvet can you please review all checkboxes in the description? Could you also take a look at the lint issue reported?
@mtrezza do i have to create issue for this? i didn't find any for this pull? AS for lint i have run :spotlessApply
please check it.
do i have to create issue for this?
that would be helpful, we want to separate issue discussion from PR (solution) discussion.
AS for lint i have run :spotlessApply please check it.
passes now
@L3K0V Do you think we can merge this?
@mtrezza LGTM
🎉 This change has been released in version 3.0.1
New Pull Request Checklist
Issue Description
Related issue: startActivityForReuslt was deprecated in adnroidx and replace with ActivityResultLauncher. So i have edited
Login
method and addedActivityResultLauncher<Intent>
as a variable.Approach
login
method has new variable forActivityResultLauncher<Intent>
which can be replaced forstartActivityForResult
. for example:TODOs before merging