Java 1.8 compile option unnecessary since Gradle 7

parse-community / Parse-SDK-Android

The Android SDK for Parse Platform

https://parseplatform.org/

Other

1.88k stars 739 forks source link

Java 1.8 compile option unnecessary since Gradle 7 #1160

Open mobilekosmos opened 2 years ago

mobilekosmos commented 2 years ago

New Feature / Enhancement Checklist

[X] I am not disclosing a vulnerability.
[X] I am not just asking a question.
[X] I have searched through existing issues.

Following block in all build.gradle files is not needed anymore since using Gradle 7 because implicitly defined: compileOptions { sourceCompatibility JavaVersion.VERSION_1_8 targetCompatibility JavaVersion.VERSION_1_8 }

Can be removed.

mtrezza commented 2 years ago

Do you want to open a PR for this?

Can you please add a reference link to an official resource that states the exact version since when Java 1.8 is used by default?

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this issue!

❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.

mobilekosmos commented 2 years ago

https://developer.android.com/studio/releases/gradle-plugin?hl=nl#java-8-default I also tried it in the past, before Gradle 7 you got a compiler error if I remember correctly if you didn't have that block in the gradle file, with Gradle 7 you don't get any error or warning when removing it.

mtrezza commented 2 years ago

Is this only relevant for when compiling the Parse Android SDK, or also for developers who add the SDK as a dependency?

azlekov commented 2 years ago

@mtrezza it's mostly relevant for this SDK as we do not know which version the users will use. Most probably all users already uses Gradle 7 and latest Android toolchains.