search

parse-community / Parse-SDK-Android

The Android SDK for Parse Platform
https://parseplatform.org/
Other
1.88k stars 735 forks source link

feat: update various dependencies #1172

Closed rommansabbir closed 2 years ago

rommansabbir commented 2 years ago

New Pull Request Checklist

Issue Description

Related issue: #1163

Approach

According to https://github.com/parse-community/Parse-SDK-Android/pull/1163#issuecomment-1139105675:

TODOs before merging

parse-github-assistant[bot] commented 2 years ago

Thanks for opening this pull request!

rommansabbir commented 2 years ago

@mtrezza CI is failing.

com.parse.ParseCorePluginsTest > testQueryControllerDefaultImpl FAILED
    java.lang.AssertionError at ParseCorePluginsTest.java:36
[Tests passed: 14 of 14 tests - my local machine - CI Fail]

com.parse.ParseDecoderTest > testCompleteness FAILED
    java.lang.AssertionError at ParseDecoderTest.java:270
[Tests passed: 23 of 23 tests - my local machine - CI Fail]

com.parse.ParseDecoderTest > testCompletenessOfIncludedParseObject FAILED
    java.lang.AssertionError at ParseDecoderTest.java:294
[Tests passed: 23 of 23 tests -  local machine - CI Fail]

Any idea on this failing?

mtrezza commented 2 years ago

Does it pass locally? If so, it may be the java version or another env version maybe.

rommansabbir commented 2 years ago

Does it pass locally? If so, it may be the java version or another env version maybe.

@mtrezza @mman any idea on how to access this file file:///home/runner/work/Parse-SDK-Android/Parse-SDK-Android/parse/build/reports/tests/testDebugUnitTest/index.html, so that I can check the stacktrace.

I ran gradle clean testDebugUnitTest command and checked the test reports. 3 test cases failing on both CI, Local but when testing through Run no errors at all.

Tried to findout the root cause but failed.

Any idea how to fix this?

mtrezza commented 2 years ago

If you want to inspect that in the CI, you would have to modify the workflow file and output the file in the console. But since you can reproduce this locally, that may not be necessary. Why can't you access Parse-SDK-Android/parse/build/reports/tests/testDebugUnitTest/index.html locally? Is there no file?

rommansabbir commented 2 years ago

If you want to inspect that in the CI, you would have to modify the workflow file and output the file in the console. But since you can reproduce this locally, that may not be necessary. Why can't you access Parse-SDK-Android/parse/build/reports/tests/testDebugUnitTest/index.html locally? Is there no file?

Actually I did founds those issues and solved too but when tested by "Run" it doesnโ€™t work but working fine in gradle clean testDebugUnitTest.

Need more time to investigate the issues, it would be more helpful if you or @mman could look at the issue too alongside with me.

rommansabbir commented 2 years ago

@mtrezza The issues arise when we are performing a gradle clean testDebugUnitTest, which remove the buildDir folder. So there is a possibilites that some of the component's build files get removed duing the clean operations, as all of the components is inter-connected to each others.

Here is the stacktraces for all failed tests.

java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertTrue(Assert.java:53) at com.parse.ParseCorePluginsTest.testQueryControllerDefaultImpl(ParseCorePluginsTest.java:37) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591) at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274) at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829)


- ParseDecoderTest

testCompleteness

java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertFalse(Assert.java:65) at org.junit.Assert.assertFalse(Assert.java:75) at com.parse.ParseDecoderTest.testCompleteness(ParseDecoderTest.java:270) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591) at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274) at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829)

testCompletenessOfIncludedParseObject

java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertFalse(Assert.java:65) at org.junit.Assert.assertFalse(Assert.java:75) at com.parse.ParseDecoderTest.testCompletenessOfIncludedParseObject(ParseDecoderTest.java:294) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:258) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.robolectric.RobolectricTestRunner$HelperTestRunner$1.evaluate(RobolectricTestRunner.java:591) at org.robolectric.internal.SandboxTestRunner$2.lambda$evaluate$0(SandboxTestRunner.java:274) at org.robolectric.internal.bytecode.Sandbox.lambda$runOnMainThread$0(Sandbox.java:88) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829)

mtrezza commented 2 years ago

It could also be helpful to go back and see with which commit this issue started to occur. If I recall correctly, we had all tests passing not so long ago.

rommansabbir commented 2 years ago

Okay. I will go through the commit changes.

rommansabbir commented 2 years ago

AGPBI: {"kind":"warning","text":"Software Components will not be created automatically for Maven publishing from Android Gradle Plugin 8.0. To opt-in to the future behavior, set the Gradle property android.disableAutomaticComponentCreation=true in the gradle.properties file or use the new publishing DSL.","sources":[{}]}

@mtrezza

codecov[bot] commented 2 years ago

Codecov Report

Merging #1172 (dab2045) into master (ec7bd03) will decrease coverage by 67.31%. The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #1172       +/-   ##
============================================
- Coverage     67.31%   0.00%   -67.32%     
============================================
  Files           122     122               
  Lines          9962    9962               
  Branches       1343    1343               
============================================
- Hits           6706       0     -6706     
- Misses         2735    9962     +7227     
+ Partials        521       0      -521
Impacted Files Coverage ฮ”
parse/src/main/java/com/parse/ParseRole.java 0.00% <0.00%> (-100.00%) :arrow_down:
parse/src/main/java/com/parse/ParseCloud.java 0.00% <0.00%> (-100.00%) :arrow_down:
parse/src/main/java/com/parse/ParseException.java 0.00% <0.00%> (-100.00%) :arrow_down:
parse/src/main/java/com/parse/ParseTextUtils.java 0.00% <0.00%> (-100.00%) :arrow_down:
parse/src/main/java/com/parse/PointerEncoder.java 0.00% <0.00%> (-100.00%) :arrow_down:
parse/src/main/java/com/parse/ParseDateFormat.java 0.00% <0.00%> (-100.00%) :arrow_down:
...rse/src/main/java/com/parse/ParseFileHttpBody.java 0.00% <0.00%> (-100.00%) :arrow_down:
...rse/src/main/java/com/parse/ParseSetOperation.java 0.00% <0.00%> (-100.00%) :arrow_down:
...se/src/main/java/com/parse/OfflineObjectStore.java 0.00% <0.00%> (-100.00%) :arrow_down:
...se/src/main/java/com/parse/http/ParseHttpBody.java 0.00% <0.00%> (-100.00%) :arrow_down:
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data Powered by Codecov. Last update c658995...dab2045. Read the comment docs.

rommansabbir commented 2 years ago

@mtrezza can you take a look at the codecov/project โ€” 0.00% (target 65.00%) fail?

mtrezza commented 2 years ago

The codecov seems to be a temporary issue:

Github API rate limit error: Forbidden Check on Codecov's status

Not sure whether we (Parse Platform) are hitting the API limit, or GitHub in general. We'll ignore this check for merge in this PR.

I see all other checks pass! That's amazing, so did you find what made it fail previously? This?

rommansabbir commented 2 years ago

I see all other checks pass! That's amazing, so did you find what made it fail previously? This?

I tried a lot of solutions but ended up with dependency issue solving. testImplementation of JUnit Jupiter & Test Task to support jUnitPlatform, that's it. Easy fix but took time ๐Ÿ˜…

mtrezza commented 2 years ago

A PR can only address and describe a single issue, so we need to consolidate the PR title.

I suggest:

feat: update various dependencies

BREAKING CHANGE: The Facebook Login SDK is upgraded to 13.x; this is a transitive dependency, so if you are directly calling the Facebook Login SDK in your app then this may be a braking change; this release of the Parse Android SDK adds a version range to the Facebook Login SDK dependency for correct gradle dependency resolving

rommansabbir commented 2 years ago

Any update on the review @parse-community/android-sdk-review?

rommansabbir commented 2 years ago

What was the idea behind adding jupiter?

It was required to execute gradle task.

I remember that Android is compatible with junit but not jupiter

In short, I went though the commits to find out which commit cause the test cases failure. But didn't found any suspicious commits. So I started focus on the dependencies, as many of the were updated to latest version.

Then in DEBUG mode, I found some of the classes were not found during the test which might causes the Illegal Access. One of them was Boolean class. So it was confirmed that test cases were failing becuase of those mentioned classes was not found.

So, I added tasks.withType(Test) {useJUnitPlatform()} since we are using Gradle 7.x. But now Gradle Task can't execute without Jupiter dependency. After adding those, test's passes without any issue, as we expected.

azlekov commented 2 years ago

@rommansabbir do you think we can migrate then to jupiter instead using junit. It's preferable to use only one library, where junit and jupiter are almost same, different versions.

rommansabbir commented 2 years ago

@rommansabbir do you think we can migrate then to jupiter instead using junit. It's preferable to use only one library, where junit and jupiter are almost same, different versions.

I think we can keep this as it is (If no issue arise). In future we have to migrate to JUnit 5.x and Jupiter is required for that.

So, we have to decide, what we want.

mtrezza commented 2 years ago

@L3K0V What do you think about merging as is with both jupiter and junit? Any concerns? I understand that we should decide on a single one, but are there also any possible (technical) side effects if we merge both?

azlekov commented 2 years ago

@mtrezza, I think we can proceed merging as it is.

mtrezza commented 2 years ago

Nice job everyone and thanks for reviving this PR @rommansabbir!

parseplatformorg commented 2 years ago

๐ŸŽ‰ This change has been released in version 4.0.0