fix: `SafeParseDelegate` ignores name parameter on `setValue`

parse-community / Parse-SDK-Android

The Android SDK for Parse Platform

https://parseplatform.org/

Other

1.88k stars 735 forks source link

fix: `SafeParseDelegate` ignores name parameter on `setValue` #1199

Open augustocarmo opened 1 year ago

augustocarmo commented 1 year ago

New Pull Request Checklist

[x] I am not disclosing a vulnerability.
[x] I am creating this PR in reference to an issue.

Issue Description

When a variable used the safeAttribute(String) function, the setValue (from the SafeParseDelegate) was not working properly when its name was different from the name param from the delegate because the name param was being ignored.

Closes: #1200

Approach

Consider the SafeParseDelegate's name param that is passed via constructor as it's done to ParseDelegate.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (f9843c5) 0.00% compared to head (e7db68b) 0.00%. Report is 2 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1199 +/- ## ====================================== Coverage 0.00% 0.00% ====================================== Files 122 122 Lines 9971 9971 Branches 1345 1345 ====================================== Misses 9971 9971 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.