parse-community / Parse-SDK-Android

The Android SDK for Parse Platform
https://parseplatform.org/
Other
1.88k stars 739 forks source link

feat: Add support for uploading a `ParseFile` from a URI #1207

Closed hej2010 closed 4 months ago

hej2010 commented 4 months ago

New Pull Request Checklist

Issue Description

Adds support for uploading a ParseFile from a Uri.

Closes: #1206

Approach

Followed the code from how it works using a File and byte[].

TODOs before merging

parse-github-assistant[bot] commented 4 months ago

Thanks for opening this pull request!

hej2010 commented 4 months ago

I added some tests but could not test it using a content uri, only from file uris

codecov[bot] commented 4 months ago

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (f9843c5) 0.00% compared to head (1c10476) 0.00%. Report is 2 commits behind head on master.

Files Patch % Lines
...arse/src/main/java/com/parse/ParseUriHttpBody.java 0.00% 37 Missing :warning:
...e/src/main/java/com/parse/ParseFileController.java 0.00% 22 Missing :warning:
.../main/java/com/parse/ParseCountingUriHttpBody.java 0.00% 20 Missing :warning:
.../src/main/java/com/parse/ParseRESTFileCommand.java 0.00% 17 Missing :warning:
parse/src/main/java/com/parse/ParseFileUtils.java 0.00% 8 Missing :warning:
parse/src/main/java/com/parse/ParseFile.java 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1207 +/- ## ======================================= Coverage 0.00% 0.00% ======================================= Files 122 124 +2 Lines 9971 10076 +105 Branches 1345 1359 +14 ======================================= - Misses 9971 10076 +105 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtrezza commented 4 months ago

Please see the failing CI

mtrezza commented 4 months ago

@rommansabbir Thanks for reviewing

parseplatformorg commented 4 months ago

🎉 This change has been released in version 4.3.0