parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
575 stars 190 forks source link

ci: Fix failing Flutter dry-run job due to missing changelog version entry #857

Closed Nidal-Bakir closed 1 year ago

Nidal-Bakir commented 1 year ago

New Pull Request Checklist

Issue Description

Closes: #856

Approach

setup Flutter rather than only Dart

TODOs before merging

N/A

parse-github-assistant[bot] commented 1 year ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9bde626) 26.35% compared to head (2db5615) 26.35%.

:exclamation: Current head 2db5615 differs from pull request most recent head dcdca87. Consider uploading reports for the commit dcdca87 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #857 +/- ## ======================================= Coverage 26.35% 26.35% ======================================= Files 47 47 Lines 2903 2903 ======================================= Hits 765 765 Misses 2138 2138 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Nidal-Bakir commented 1 year ago

@mtrezza
The CI issue fixed


Parse-SDK-Flutter/Parse-SDK-Flutter/packages/flutter/CHANGELOG.md doesn't mention current version (4.0.0). Consider updating it with notes on this version prior to publication.

its now complaining about not mentioning the new 4.0.0 version in the CHANGELOG like the other release versions

mtrezza commented 1 year ago

Is it just looking for the string 4.0.0? Could you try changing the changelog line to 4.0.0 (unreleased)

Nidal-Bakir commented 1 year ago

Yes, that will make it happy. should I revert the last commit and open a new PR to fix this?

this (4.0.0) Unreleased or (4.0.0) Unreleased both will work

mtrezza commented 1 year ago

I think this is good now