parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
575 stars 190 forks source link

fix: Query conditions `inQuery` and `notInQuery` not working properly #869

Closed mbfakourii closed 1 year ago

mbfakourii commented 1 year ago

New Pull Request Checklist

Issue Description

There was an unused "," value in the _buildQueryRelational function

Closes: #849

Approach

n/a

TODOs before merging

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d1b07fe). Click here to learn what that means. Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 934a090 differs from pull request most recent head 98a24cd. Consider uploading reports for the commit 98a24cd to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #869 +/- ## ========================================= Coverage ? 39.13% ========================================= Files ? 56 Lines ? 3278 Branches ? 0 ========================================= Hits ? 1283 Misses ? 1995 Partials ? 0 ``` | [Impacted Files](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [packages/dart/lib/src/network/parse\_query.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/869?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZGFydC9saWIvc3JjL25ldHdvcmsvcGFyc2VfcXVlcnkuZGFydA==) | `32.42% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mtrezza commented 1 year ago

Is this ready for review?

mbfakourii commented 1 year ago

Is this ready for review?

Yes, it is ready for review

Nidal-Bakir commented 1 year ago

Can you add a test to ensure that this does not happen again?

mbfakourii commented 1 year ago

Can you add a test to ensure that this does not happen again?

Yes, sure

mbfakourii commented 1 year ago

@mtrezza Why did half of the CI failed?

Nidal-Bakir commented 1 year ago

Why did half of the CI failed?

See https://github.com/parse-community/Parse-SDK-Flutter/pull/874 and https://github.com/parse-community/Parse-SDK-Flutter/issues/872#issuecomment-1544985663

mbfakourii commented 1 year ago

Looks good, could you just rephrase the PR title, it seems to describe the technical solution instead of the bug that is fixed by this PR; so that we have a meaningful changelog entry

I changed The problem is very small. I don't have a better idea for the title

mbfakourii commented 1 year ago

Could you add a changelog entry?

added