refactor: Remove deprecated property `window` from `dart:ui` in favor of `PlatformDispatcher`

Nidal-Bakir commented 1 year ago

New Pull Request Checklist

[x] I am not disclosing a vulnerability.
[x] I am creating this PR in reference to an issue.

Issue Description

Closes: #877

Approach

Use the PlatformDispatcher class as recommended by the Flutter docs see window class docs

TODOs before merging

[ ] Add tests
[ ] Add changes to documentation (guides, repository pages, in-code descriptions)
[ ] A changelog entry

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 :warning:

Comparison is base (518f768) 38.69% compared to head (1e982e9) 38.68%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #878 +/- ## ========================================== - Coverage 38.69% 38.68% -0.02% ========================================== Files 56 56 Lines 3277 3278 +1 ========================================== Hits 1268 1268 - Misses 2009 2010 +1 ``` | [Impacted Files](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [packages/flutter/lib/parse\_server\_sdk\_flutter.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/878?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZmx1dHRlci9saWIvcGFyc2Vfc2VydmVyX3Nka19mbHV0dGVyLmRhcnQ=) | `8.62% <50.00%> (-0.16%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mtrezza commented 1 year ago

Is this a breaking change or only an internal refactor without any effects for developers?

Nidal-Bakir commented 1 year ago

Internal refactor the developers will not notice it

mtrezza commented 1 year ago

Alright, so we also don't need a changelog entry for it. All looks green - yay! - can we merge this?

Nidal-Bakir commented 1 year ago

sure, we can!!!!!!!! finally :)

mtrezza commented 1 year ago

Is this the last breaking change for the Parse Flutter SDK? If so, we could release Flutter 5.0.0 with this PR.

Why do we need https://github.com/parse-community/Parse-SDK-Flutter/pull/868 if all checks are green in this PR already? That would be another breaking change we'd probably have to include before a Flutter 5 release.
The Dart SDK has a version constant const String keySdkVersion = '5.0.0'; in parse_constants.dart that needs to be kept in sync manually with the version in pubspec.yaml. Does the Flutter SDK have something similar?

Nidal-Bakir commented 1 year ago

Why do we need https://github.com/parse-community/Parse-SDK-Flutter/pull/868 if all checks are green in this PR already? That would be another breaking change we'd probably have to include before a Flutter 5 release.

But then if anyone uses Flutter SDK will be locked to Dart SDK 4.x.x. And will not see any updates on the Dart SDK. because the Flutter SDK constraint it to <5.0.0

The Dart SDK has a version constant const String keySdkVersion = '5.0.0'; in parse_constants.dart that needs to be kept in sync manually with the version in pubspec.yaml. Does the Flutter SDK have something similar?

No, there is nothing like that in the Flutter SDK

mtrezza commented 1 year ago

Alright, I'll go ahead and merge.

parse-community / Parse-SDK-Flutter