Closed Nidal-Bakir closed 1 year ago
Patch coverage: 50.00
% and project coverage change: -0.02
:warning:
Comparison is base (
518f768
) 38.69% compared to head (1e982e9
) 38.68%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Is this a breaking change or only an internal refactor without any effects for developers?
Internal refactor the developers will not notice it
Alright, so we also don't need a changelog entry for it. All looks green - yay! - can we merge this?
sure, we can!!!!!!!! finally :)
Is this the last breaking change for the Parse Flutter SDK? If so, we could release Flutter 5.0.0 with this PR.
const String keySdkVersion = '5.0.0';
in parse_constants.dart
that needs to be kept in sync manually with the version in pubspec.yaml
. Does the Flutter SDK have something similar?Why do we need https://github.com/parse-community/Parse-SDK-Flutter/pull/868 if all checks are green in this PR already? That would be another breaking change we'd probably have to include before a Flutter 5 release.
But then if anyone uses Flutter SDK will be locked to Dart SDK 4.x.x. And will not see any updates on the Dart SDK. because the Flutter SDK constraint it to <5.0.0
The Dart SDK has a version constant const String keySdkVersion = '5.0.0'; in parse_constants.dart that needs to be kept in sync manually with the version in pubspec.yaml. Does the Flutter SDK have something similar?
No, there is nothing like that in the Flutter SDK
Alright, I'll go ahead and merge.
New Pull Request Checklist
Issue Description
Closes: #877
Approach
Use the PlatformDispatcher class as recommended by the Flutter docs see window class docs
TODOs before merging