parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
575 stars 190 forks source link

ci: Fix manual release workflow #891

Closed mtrezza closed 1 year ago

mtrezza commented 1 year ago

New Pull Request Checklist

Issue Description

Fix pre-release checks in release workflow not set up properly.

Closes: #881

Approach

Fix pre-release checks in workflow.

parse-github-assistant[bot] commented 1 year ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

mtrezza commented 1 year ago

I've used the steps from the CI, since some seemed to be missing for flutter. I still haven't added this step:

- name: Run build_runner
   run: (cd packages/dart && dart run build_runner build --delete-conflicting-outputs)

Is this required in the release workflow?

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9f2d2d6) 38.68% compared to head (e849cd8) 38.68%.

:exclamation: Current head e849cd8 differs from pull request most recent head 9533b37. Consider uploading reports for the commit 9533b37 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #891 +/- ## ======================================= Coverage 38.68% 38.68% ======================================= Files 56 56 Lines 3278 3278 ======================================= Hits 1268 1268 Misses 2010 2010 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Nidal-Bakir commented 1 year ago

No, it is not required