parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
575 stars 186 forks source link

refactor: Add pubspec in dart example #908

Closed mbfakourii closed 1 year ago

mbfakourii commented 1 year ago

Pull Request

Issue

add pubspec in dart example and fix main.dart example warning

Closes: #905

Approach

n/a

Tasks

n/a

parse-github-assistant[bot] commented 1 year ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +2.74 :tada:

Comparison is base (7bfce0f) 39.13% compared to head (1a0ebad) 41.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #908 +/- ## ========================================== + Coverage 39.13% 41.88% +2.74% ========================================== Files 56 51 -5 Lines 3278 2994 -284 ========================================== - Hits 1283 1254 -29 + Misses 1995 1740 -255 ``` [see 5 files with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/908/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mtrezza commented 1 year ago

It's a fix in the example, which is not part of the SDK itself, so this is merely a refactor and won't cause a release.

mbfakourii commented 1 year ago

Looks good, ready for merge?

Yes, I think it is ready

Nidal-Bakir commented 1 year ago

Could you run the following command to see if there are any errors: dart analyze packages/dart --fatal-infos

Nidal-Bakir commented 1 year ago

I just tested it with dart analyze packages/dart --fatal-infos no issues were found. We are good to publish Dart 5.1.1

Nidal-Bakir commented 1 year ago

See https://github.com/parse-community/Parse-SDK-Flutter/pull/906#issuecomment-1554221396

mtrezza commented 1 year ago

Can this PR be merged despite the failing CI?

mbfakourii commented 1 year ago

Can this PR be merged despite the failing CI?

This error is related to the version of Flutter, merge it and there will be no problem