Closed Nidal-Bakir closed 1 year ago
Patch coverage has no change and project coverage change: -2.75
:warning:
Comparison is base (
e097da5
) 41.88% compared to head (4ce07d6
) 39.13%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
CI failed, should this PR be merged anyway because it fixes only a part?
CI failed, should this PR be merged anyway because it fixes only a part?
This error is related to Dart version, I think you should merge #908 first, then merge this PR
CI is still failing.
We have another warning in Flutter 3.10
info • Use 'const' with the constructor to improve performance • packages/flutter/example/lib/live_list/main.dart:52:23 • prefer_const_constructors
@Nidal-Bakir
I think it needs const
Thats a problem!
We can not use const
here because its only support in flutter 3.10.0
Thats a problem! We can not use
const
here because its only support in flutter 3.10.0
I think it is better to create a variable and then give the variable to child
That's a good idea. but it is a temporary solution.
I'm starting to smell a revert PR. for this PR #906 and remove the --fatal-infos
flag from the CI/CD
Any new rules/lints in Flutter 3.10.0 that can not be applied in Flutter <3.10.0 will cause a problem.
@mbfakourii
I think we need to remove the --fatal-infos
flag from CI/CD. because we are testing on Flutter version 3.3 up to 3.10. More issues like this will rise.
@mbfakourii
I think we need to remove the--fatal-infos
flag from CI/CD. because we are testing on Flutter version 3.3 up to 3.10. More issues like this will rise.
Are the warnings completely hidden by removing this flag, for example the format code warning?
This has nothing to do with the code format. That's a other command called dart format
This has nothing to do with the code format. That's a other command called
dart format
I'm afraid we're missing some warnings, if you're sure, then remove them
We will likely miss some warning or info messages if we remove the --fatal-infos
flag. Alternatively, we could monitor if this causes any issues and remove it if necessary.
We are good to go!
Pull Request
Issue
Closes: #910
Approach
Tasks