parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
575 stars 186 forks source link

fix: Push notifications in iOS not working #940

Closed mbfakourii closed 1 year ago

mbfakourii commented 1 year ago

Pull Request

Issue

Changing awesome_notifications package to flutter_local_notifications in ParseNotification

Closes: #936

Approach

n/a

Tasks

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.16 :warning:

Comparison is base (bae8902) 39.50% compared to head (de31fe0) 39.34%.

:exclamation: Current head de31fe0 differs from pull request most recent head 052f7a1. Consider uploading reports for the commit 052f7a1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #940 +/- ## ========================================== - Coverage 39.50% 39.34% -0.16% ========================================== Files 60 60 Lines 3339 3355 +16 ========================================== + Hits 1319 1320 +1 - Misses 2020 2035 +15 ``` | [Impacted Files](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [packages/flutter/lib/parse\_server\_sdk\_flutter.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZmx1dHRlci9saWIvcGFyc2Vfc2VydmVyX3Nka19mbHV0dGVyLmRhcnQ=) | `20.00% <ø> (ø)` | | | [...utter/lib/src/notification/parse\_notification.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZmx1dHRlci9saWIvc3JjL25vdGlmaWNhdGlvbi9wYXJzZV9ub3RpZmljYXRpb24uZGFydA==) | `0.00% <0.00%> (ø)` | | | [packages/flutter/lib/src/push/parse\_push.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/940?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZmx1dHRlci9saWIvc3JjL3B1c2gvcGFyc2VfcHVzaC5kYXJ0) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/940/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mbfakourii commented 1 year ago

@mtrezza Ready to merge?

mtrezza commented 1 year ago

Is this package change in any way a breaking change for developers, or is that only internally?

mbfakourii commented 1 year ago

Is this package change in any way a breaking change for developers, or is that only internally?

No, it is not a breaking change, only internally

mtrezza commented 1 year ago

Got it; since this is a bug fix, could you change the PR title to describe the bug?

parse-github-assistant[bot] commented 1 year ago

I will reformat the title to use the proper commit message syntax.