parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
575 stars 190 forks source link

fix: Building web app fails because `dbDirectory` does not exist in `core_store_directory_web` #948

Closed mbfakourii closed 1 year ago

mbfakourii commented 1 year ago

Pull Request

Issue

move dbDirectory to core_store_sembast

Closes: #947

Approach

n/a

Tasks

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.02 :tada:

Comparison is base (ac682f2) 39.31% compared to head (854e42d) 39.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #948 +/- ## ========================================== + Coverage 39.31% 39.34% +0.02% ========================================== Files 60 60 Lines 3355 3355 ========================================== + Hits 1319 1320 +1 + Misses 2036 2035 -1 ``` | [Impacted Files](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community) | Coverage Δ | | |---|---|---| | [packages/flutter/lib/parse\_server\_sdk\_flutter.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZmx1dHRlci9saWIvcGFyc2Vfc2VydmVyX3Nka19mbHV0dGVyLmRhcnQ=) | `20.00% <ø> (ø)` | | | [...utter/lib/src/storage/core\_store\_directory\_io.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZmx1dHRlci9saWIvc3JjL3N0b3JhZ2UvY29yZV9zdG9yZV9kaXJlY3RvcnlfaW8uZGFydA==) | `100.00% <ø> (+13.04%)` | :arrow_up: | | [...es/flutter/lib/src/storage/core\_store\_sembast.dart](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/948?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community#diff-cGFja2FnZXMvZmx1dHRlci9saWIvc3JjL3N0b3JhZ2UvY29yZV9zdG9yZV9zZW1iYXN0LmRhcnQ=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/parse-community/Parse-SDK-Flutter/pull/948/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=parse-community)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

keanallen commented 1 year ago

up for this

sgehrman commented 1 year ago

merge it. It currently is useless as it doesn't even build. Update your packages while your at it.

sgehrman commented 1 year ago

update this while you're at it:

environment: sdk: '>=3.0.0 <4.0.0'

If someone is using Dart 2, that's their problem.

sgehrman commented 1 year ago

why does it take a week to merge a super tiny change? Get a clue, people are using this package. Should have taken 5 minutes to post a new build.

keanallen commented 1 year ago

why does it take a week to merge a super tiny change? Get a clue, people are using this package. Should have taken 5 minutes to post a new build.

It has to be tested first to ensure quality and lessen bugs

mtrezza commented 1 year ago

@sgehrman It's important to remember that this package is maintained by open source volunteers who generously contribute their time and effort. While it's understandable to be eager for updates, let's appreciate the hard work of the volunteers and the fact that they are dedicating their free time to support this project. If you have specific concerns or suggestions, it's helpful to express them respectfully and engage in constructive discussions. If you want to help to get this pull request merged faster, feel free to test it out and post your feedback here.