parse-community / Parse-SDK-Flutter

The Dart/Flutter SDK for Parse Platform
https://parseplatform.org
Apache License 2.0
573 stars 188 forks source link

refactor: Update `connectivity_plus` to 4.0.1 #954

Closed DirkoOdendaal closed 10 months ago

DirkoOdendaal commented 1 year ago

Pull Request

Issue

Closes: 945

Approach

Just updating connectivity_plus to latest version. This should solve issues with using connectivity_plus and this package together in the same project.

parse-github-assistant[bot] commented 1 year ago

I will reformat the title to use the proper commit message syntax.

parse-github-assistant[bot] commented 1 year ago

Thanks for opening this pull request!

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (c9d64cb) 39.31% compared to head (8c18917) 39.31%.

:exclamation: Current head 8c18917 differs from pull request most recent head 081702f. Consider uploading reports for the commit 081702f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #954 +/- ## ======================================= Coverage 39.31% 39.31% ======================================= Files 60 60 Lines 3355 3355 ======================================= Hits 1319 1319 Misses 2036 2036 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mtrezza commented 1 year ago

This should solve issues with using connectivity_plus and this package together in the same project.

What issues would that be?

This is a major version upgrade from 3.x to 4.x; are there any implications like breaking changes for developers?

mbfakourii commented 1 year ago

This is a major version upgrade from 3.x to 4.x; are there any implications like breaking changes for developers?

No, this is not breaking changes

I think it is ready for merge

mtrezza commented 1 year ago

CI fails with:

ERR : Because connectivity_plus >=3.0.0 depends on flutter_web_plugins from sdk which depends on js 0.6.4, connectivity_plus >=3.0.0 requires js 0.6.4.

mbfakourii commented 1 year ago

It is strange that the rest of the tests did not fail ! Can you run it again?

mbfakourii commented 1 year ago

I think js: ^0.6.5 should also be added

mtrezza commented 1 year ago

It seems that the tests pass now.

mbfakourii commented 1 year ago

test failed !

Because connectivity_plus >=3.0.0 depends on flutter_web_plugins from sdk which depends on js 0.6.4, connectivity_plus >=3.0.0 requires js 0.6.4.
So, because parse_server_sdk_flutter depends on both connectivity_plus ^4.0.1 and js ^0.6.5, version solving failed.
mbfakourii commented 1 year ago

@DirkoOdendaal

I think it is better to do a test in ‍Flutter 3.3

DirkoOdendaal commented 1 year ago

Yes, I'm busy looking at the dependency issues between flutter and the connectivity_plus package.

mbfakourii commented 10 months ago

According to the support policy, I think it is better to close this PR.