Closed DirkoOdendaal closed 10 months ago
I will reformat the title to use the proper commit message syntax.
Patch and project coverage have no change.
Comparison is base (
c9d64cb
) 39.31% compared to head (8c18917
) 39.31%.:exclamation: Current head 8c18917 differs from pull request most recent head 081702f. Consider uploading reports for the commit 081702f to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This should solve issues with using connectivity_plus and this package together in the same project.
What issues would that be?
This is a major version upgrade from 3.x to 4.x; are there any implications like breaking changes for developers?
This is a major version upgrade from 3.x to 4.x; are there any implications like breaking changes for developers?
No, this is not breaking changes
I think it is ready for merge
CI fails with:
ERR : Because connectivity_plus >=3.0.0 depends on flutter_web_plugins from sdk which depends on js 0.6.4, connectivity_plus >=3.0.0 requires js 0.6.4.
It is strange that the rest of the tests did not fail ! Can you run it again?
I think js: ^0.6.5
should also be added
It seems that the tests pass now.
test failed !
Because connectivity_plus >=3.0.0 depends on flutter_web_plugins from sdk which depends on js 0.6.4, connectivity_plus >=3.0.0 requires js 0.6.4.
So, because parse_server_sdk_flutter depends on both connectivity_plus ^4.0.1 and js ^0.6.5, version solving failed.
@DirkoOdendaal
I think it is better to do a test in Flutter 3.3
Yes, I'm busy looking at the dependency issues between flutter and the connectivity_plus package.
According to the support policy, I think it is better to close this PR.
Pull Request
Issue
Closes: 945
Approach
Just updating connectivity_plus to latest version. This should solve issues with using connectivity_plus and this package together in the same project.